Introduce a netlink alloc driver . #1981
Merged
+355
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Databean
reviewed
Jan 8, 2026
Databean
reviewed
Jan 8, 2026
3405691582
force-pushed
the
netlink_4
branch
4 times, most recently
from
91742de to
7cd96a6
Compare
Databean
approved these changes
Jan 9, 2026
We're now in the position to introduce a netlink driver. This driver allows cvdalloc to (transitively) set up nearly all of the network allocation and deallocation steps in a faster, more idiomatic way than shelling out to ip(8). Only one driver operation still requires shelling out to iptables(8). We can potentially use NETLINK_NETFILTER to do this in the future but this is actually somewhat more painful and involved than using netlink for the other driver operations. Maybe we can do this in the future; left as a TODO for now. To use the driver until the default is changed, one can rebuild cvd with the `--//allocd:driver=netlink` custom bazel flag; without the flag, the the iproute2 driver is the default, for reasons mentioned in earlier commits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're now in the position to introduce a netlink driver. This driver allows cvdalloc to (transitively) set up nearly all of the network allocation and deallocation steps in a faster, more idiomatic way than shelling out to ip(8).
Only one driver operation still requires shelling out to iptables(8). We can potentially use NETLINK_NETFILTER to do this in the future but this is actually somewhat more painful and involved than using netlink for the other driver operations. Maybe we can do this in the future; left as a TODO for now.
To use the driver until the default is changed, one can rebuild cvd with the
--//allocd:driver=netlinkcustom bazel flag; without the flag, the the iproute2 driver is the default, for reasons mentioned in earlier commits.